Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 159632: Change the overly-general class named Node to the more specific... (Closed)

Created:
11 years, 4 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Change the overly-general class named Node to the more specific AstNode in case we ever want to have some other kind of node. Split the NODE_LIST macro-generating macro so that we can iterate concrete subclasses of Statement and concrete subclasses of Expression separately. Committed: http://code.google.com/p/v8/source/detail?r=2586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 9 chunks +16 lines, -11 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/prettyprinter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/usage-analyzer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 4 months ago (2009-07-30 11:47:42 UTC) #1
Kasper Lund
11 years, 4 months ago (2009-07-30 11:50:01 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698