Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1596025: Move third_pary/mozilla/include up one directory. (Closed)

Created:
10 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Move third_pary/mozilla/include up one directory. This allows the license checker to find the README. BUG=39240 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M chrome/browser/cocoa/bookmark_bar_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_folder_target.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/url_drop_target.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/web_drag_source.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/web_drop_target.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/web_drop_target_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +10 lines, -10 lines 0 comments Download
A + third_party/mozilla/NSPasteboard+Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSPasteboard+Utils.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSScreen+Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSScreen+Utils.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSString+Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSString+Utils.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSURL+Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSURL+Utils.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSWorkspace+Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/NSWorkspace+Utils.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/mozilla/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/glue/plugins/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Martin
The deleted DEPS file is due to a change by JAM in Oct 2009 that ...
10 years, 8 months ago (2010-04-14 22:45:39 UTC) #1
Nico
Wouldn't it be easier to move up only the readme? Or let the license script ...
10 years, 8 months ago (2010-04-14 22:50:33 UTC) #2
Evan Martin
I did consider those options, but I don't see the point in having two layers ...
10 years, 8 months ago (2010-04-14 22:52:25 UTC) #3
jam
lgtm On Wed, Apr 14, 2010 at 3:52 PM, <evan@chromium.org> wrote: > I did consider ...
10 years, 8 months ago (2010-04-14 22:58:57 UTC) #4
pink (ping after 24hrs)
10 years, 8 months ago (2010-04-15 14:24:28 UTC) #5
You should be able to use the trybots. I've used them for large code
moves before.

On Wed, Apr 14, 2010 at 6:58 PM, John Abd-El-Malek <jam@chromium.org> wrote:
> lgtm
>
> On Wed, Apr 14, 2010 at 3:52 PM, <evan@chromium.org> wrote:
>>
>> I did consider those options, but I don't see the point in having two
>> layers of
>> directories here anyway.
>>
>> http://codereview.chromium.org/1596025/show
>
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

Powered by Google App Engine
This is Rietveld 408576698