Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1596022: Add commands stack and mem to ARM simulator debugger... (Closed)

Created:
10 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add commands stack and mem to ARM simulator debugger The command "stack" will dump the stack and "mem" will dump memory from a address given either as a register or as a literal. Both commands dump 10 words unless an additional argument with the number of words to dump is given. sim> stack sim> mem fp sim> mem 0xe612a450 100 Also parse address literals in simulator debugger command as unsigned. Committed: http://code.google.com/p/v8/source/detail?r=4388

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -8 lines) Patch
M src/arm/simulator-arm.cc View 1 10 chunks +49 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-12 12:02:36 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/1596022/diff/1/2 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/1596022/diff/1/2#newcode350 src/arm/simulator-arm.cc:350: PrintF(" 0x%08x 0x%08x %10d\n", cur, *cur, *cur); A ...
10 years, 8 months ago (2010-04-12 12:09:25 UTC) #2
Søren Thygesen Gjesse
10 years, 8 months ago (2010-04-12 12:22:38 UTC) #3
http://codereview.chromium.org/1596022/diff/1/2
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/1596022/diff/1/2#newcode350
src/arm/simulator-arm.cc:350: PrintF("  0x%08x  0x%08x %10d\n", cur, *cur,
*cur);
On 2010/04/12 12:09:25, Erik Corry wrote:
> A colon after the first %08x might make this clearer.

Done.

Powered by Google App Engine
This is Rietveld 408576698