Dev server: Support image hosting for factory install.

Dev server: Support image hosting for factory install.

Adds two new command-line options to the dev server:

--factory_config <filename>: If set, images will be returned according
to the configuration set in the filename. The format of this is
documented by example in sample_factory_server.conf.

--validate_factory_config: If this is set along w/ the previous
option, the checksums in the factory config will be verified.

[rtc, 2010-04-09 06:05:55]

Here's some quick comments. I'll take a closer look shortly.

http://codereview.chromium.org/1596016/diff/1/2
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/1596016/diff/1/2#newcode9
src/platform/dev/autoupdate.py:9: import sys
please put in alpha order.

http://codereview.chromium.org/1596016/diff/1/2#newcode134
src/platform/dev/autoupdate.py:134: def ImportFactorConfigFile(self, filename,
validate_checksums=False):
This file doesn't set a good example, but we should fix it going forward. 

Could you add a comment for the function. The format is usually a multi-line
string in the body. 

example

def foo():
  """
    foo saves kittens...
  """

http://codereview.chromium.org/1596016/diff/1/2#newcode134
src/platform/dev/autoupdate.py:134: def ImportFactorConfigFile(self, filename,
validate_checksums=False):
Also, did you want to call this ImportFactoryConfigFile?

http://codereview.chromium.org/1596016/diff/1/2#newcode136
src/platform/dev/autoupdate.py:136: exec(f.read())
might want to do something like this instead

output = {}
exec(data, output)

This will prevent the data that you exec from doing anything to the current
scope

http://codereview.chromium.org/1596016/diff/1/2#newcode154
src/platform/dev/autoupdate.py:154: sys.exit(1)
why not raise an exception instead of using sys.exit()?

[rginda, 2010-04-09 18:23:17]

http://codereview.chromium.org/1596016/diff/1/2
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/1596016/diff/1/2#newcode134
src/platform/dev/autoupdate.py:134: def ImportFactorConfigFile(self, filename,
validate_checksums=False):
Also Also, the Python style guide has some specific suggestions about how to
format docstrings:

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Comments

http://codereview.chromium.org/1596016/diff/1/2#newcode140
src/platform/dev/autoupdate.py:140: for kind in ['factory', 'release']:
This could be a tuple rather than a list, ie ('factory', 'release')

http://codereview.chromium.org/1596016/diff/1/2#newcode157
src/platform/dev/autoupdate.py:157: sys.exit(0)
Similar to rtc above, why not just return and let the script exit normally?

Also, no need for else: after exit, return or raise

[adlr, 2010-04-09 23:38:19]

please take another look. thanks!

http://codereview.chromium.org/1596016/diff/1/2
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/1596016/diff/1/2#newcode9
src/platform/dev/autoupdate.py:9: import sys
On 2010/04/09 06:05:55, rtc wrote:
> please put in alpha order. 

Done.

http://codereview.chromium.org/1596016/diff/1/2#newcode134
src/platform/dev/autoupdate.py:134: def ImportFactorConfigFile(self, filename,
validate_checksums=False):
On 2010/04/09 06:05:55, rtc wrote:
> This file doesn't set a good example, but we should fix it going forward. 
> 
> Could you add a comment for the function. The format is usually a multi-line
> string in the body. 
> 
> example
> 
> def foo():
>   """
>     foo saves kittens...
>   """

Done.

http://codereview.chromium.org/1596016/diff/1/2#newcode134
src/platform/dev/autoupdate.py:134: def ImportFactorConfigFile(self, filename,
validate_checksums=False):
On 2010/04/09 06:05:55, rtc wrote:
> Also, did you want to call this ImportFactoryConfigFile?

yes, done.

http://codereview.chromium.org/1596016/diff/1/2#newcode134
src/platform/dev/autoupdate.py:134: def ImportFactorConfigFile(self, filename,
validate_checksums=False):
On 2010/04/09 18:23:17, rginda wrote:
> Also Also, the Python style guide has some specific suggestions about how to
> format docstrings:
> 
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Comments
> 

Done.

http://codereview.chromium.org/1596016/diff/1/2#newcode136
src/platform/dev/autoupdate.py:136: exec(f.read())
On 2010/04/09 06:05:55, rtc wrote:
> might want to do something like this instead
> 
> output = {}
> exec(data, output)
> 
> This will prevent the data that you exec from doing anything to the current
> scope

Done.

http://codereview.chromium.org/1596016/diff/1/2#newcode140
src/platform/dev/autoupdate.py:140: for kind in ['factory', 'release']:
On 2010/04/09 18:23:17, rginda wrote:
> This could be a tuple rather than a list, ie ('factory', 'release')

Done.

http://codereview.chromium.org/1596016/diff/1/2#newcode154
src/platform/dev/autoupdate.py:154: sys.exit(1)
On 2010/04/09 06:05:55, rtc wrote:
> why not raise an exception instead of using sys.exit()?

Done.

http://codereview.chromium.org/1596016/diff/1/2#newcode157
src/platform/dev/autoupdate.py:157: sys.exit(0)
On 2010/04/09 18:23:17, rginda wrote:
> Similar to rtc above, why not just return and let the script exit normally?
> 
> Also, no need for else: after exit, return or raise

fixed

[rginda, 2010-04-12 18:16:25]

LGTM