Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/common.sh

Issue 1596015: Use gcc-mp-4.4 to build TSan on Mac.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/build-tsan-for-chromium.sh ('k') | scripts/macports-gcc-wrapper/g++ » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/common.sh
===================================================================
--- scripts/common.sh (revision 43828)
+++ scripts/common.sh (working copy)
@@ -202,12 +202,13 @@
build_valgrind "linux_x86" "--enable-only32bit"
;;
"Darwin i386")
- if [ `uname -r` != "9.7.0" ]; then
- echo "You have Darwin kernel different than 9.7.0"
- echo "We've tested binaries built on 9.7.0 to work with 9.6.1, 9.7.0 and 9.8.0"
+ if uname -r | grep 9\.[0-9]\.[0-9] >/dev/null
+ then
+ build_valgrind "mac"
+ else
+ echo "You have Darwin kernel different from 9.X.X" >&2
+ echo "Please, don't put the resulting binaries into Chromium SVN" >&2
build_valgrind "local"
- else
- build_valgrind "mac"
fi
;;
*)
« no previous file with comments | « scripts/build-tsan-for-chromium.sh ('k') | scripts/macports-gcc-wrapper/g++ » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698