Issue 159568: Update smoketests.py so we can run ui_tests in parallel, with...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159568: Update smoketests.py so we can run ui_tests in parallel, with... (Closed)

Created:
11 years, 4 months ago by huanr

Modified:
9 years ago

Reviewers:
jam, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update smoketests.py so we can run ui_tests in parallel, with the number of shards equal to NUMBER_OF_PROCESSORS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21996

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -1 line)			Patch
	M	chrome/tools/test/smoketests.py	View	1 2	2 chunks	+37 lines, -1 line	1 comment	Download
	M	tools/python/google/process_utils.py	View		1 chunk	+86 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm, awesome http://codereview.chromium.org/159568/diff/1001/7 File chrome/tools/test/smoketests.py (right): http://codereview.chromium.org/159568/diff/1001/7#newcode128 Line 128: processor_count = int(os.environ['NUMBER_OF_PROCESSORS']) This might not ...

11 years, 4 months ago (2009-07-29 18:07:03 UTC) #2

M-A Ruel

11 years, 4 months ago (2009-07-29 22:24:46 UTC) #3

http://codereview.chromium.org/159568/diff/1005/9
File chrome/tools/test/smoketests.py (right):

http://codereview.chromium.org/159568/diff/1005/9#newcode128
Line 128: processor_count = 2
nit: I think it should default to 1.

http://codereview.chromium.org/159568/diff/1005/8
File tools/python/google/process_utils.py (right):

http://codereview.chromium.org/159568/diff/1005/8#newcode201
Line 201: # Windows Python converts \n to \r\n automatically whenever it
This looks odd.
sys.stdout.write(line + '\n')
will work fine and doesn't need a 7 line comment. :)

Expand Messages | Collapse Messages

Issue 159568: Update smoketests.py so we can run ui_tests in parallel, with... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages