Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issue 159542: Add a WebKit API that registers a V8 extension to be loaded into content (Closed)

Created:
11 years, 4 months ago by Matt Perry
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a WebKit API that registers a V8 extension to be loaded into content scripts. BUG=11797 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22091

Patch Set 1 #

Patch Set 2 : tagged contexts #

Patch Set 3 : final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -35 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/renderer/extension_groups.h View 2 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/renderer_extension_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/js_only_v8_extensions.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 chunks +18 lines, -11 lines 0 comments Download
M chrome/renderer/user_script_slave.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/api/public/WebKit.h View 1 1 chunk +9 lines, -4 lines 0 comments Download
M webkit/api/src/WebKit.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/webframe.h View 2 1 chunk +12 lines, -4 lines 0 comments Download
M webkit/glue/webframe_impl.h View 2 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 2 3 chunks +6 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
There's a corresponding webkit change, but I want to see what you think about the ...
11 years, 4 months ago (2009-07-28 21:47:29 UTC) #1
Aaron Boodman
API lgtm
11 years, 4 months ago (2009-07-28 22:25:14 UTC) #2
abarth-chromium
I'm surprised you don't need to change test_shell to make it compile.
11 years, 4 months ago (2009-07-29 20:14:24 UTC) #3
Matt Perry
11 years, 4 months ago (2009-07-29 20:20:04 UTC) #4
On 2009/07/29 20:14:24, abarth wrote:
> I'm surprised you don't need to change test_shell to make it compile.

I haven't compiled test_shell yet (or run the try servers). Thanks for the heads
up, I'll make sure it still works.

Powered by Google App Engine
This is Rietveld 408576698