Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: src/platform-linux.cc

Issue 159538: - getc returns an int. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-linux.cc
===================================================================
--- src/platform-linux.cc (revision 2565)
+++ src/platform-linux.cc (working copy)
@@ -233,9 +233,9 @@
char attr_r, attr_w, attr_x, attr_p;
if (fscanf(fp, "%" V8PRIxPTR "-%" V8PRIxPTR, &start, &end) != 2) break;
if (fscanf(fp, " %c%c%c%c", &attr_r, &attr_w, &attr_x, &attr_p) != 4) break;
- char c;
+ int c;
if (attr_r == 'r' && attr_x == 'x') {
- while (c = getc(fp), c != EOF && c != '\n' && c != '/');
+ while (c = getc(fp), (c != EOF) && (c != '\n') && (c != '/'));
char lib_name[1024];
bool lib_has_name = false;
if (c == '/') {
@@ -250,7 +250,7 @@
}
LOG(SharedLibraryEvent(lib_name, start, end));
}
- while (c = getc(fp), c != EOF && c != '\n');
+ while (c = getc(fp), (c != EOF) && (c != '\n'));
}
fclose(fp);
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698