Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1595018: Change |scm.GIT.GenerateDiff| and |scm.GIT.GetDifferentFiles| to ignore unmerged upstream changes. (Closed)

Created:
10 years, 8 months ago by Bernhard Bauer
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Change |scm.GIT.GenerateDiff| and |scm.GIT.GetDifferentFiles| to ignore unmerged upstream changes. Similar to r43313, this CL makes |git try| use the same patch that |git cl upload| uploads. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M scm.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bernhard Bauer
Could you review this? I changed git diff-tree to git diff, because diff-tree doesn't accept ...
10 years, 8 months ago (2010-04-09 10:22:52 UTC) #1
Evan Martin
10 years, 8 months ago (2010-04-09 16:01:53 UTC) #2
M-A Ruel
10 years, 8 months ago (2010-04-09 16:57:05 UTC) #3
I'm not intimate with all the git algos, "as long as it works".

Make sure ./presubmit_support.py *.py returns success.

lgtm

Powered by Google App Engine
This is Rietveld 408576698