src/ia32/stub-cache-ia32.cc - Issue 159500: Fix pixel array support for x64 and make the fast Array functions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 159500: Fix pixel array support for x64 and make the fast Array functions... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

===================================================================

--- src/ia32/stub-cache-ia32.cc (revision 2555)

+++ src/ia32/stub-cache-ia32.cc (working copy)

@@ -680,13 +680,13 @@

case JSARRAY_HAS_FAST_ELEMENTS_CHECK:

CheckPrototypes(JSObject::cast(object), edx, holder,

ebx, ecx, name, &miss);

- // Make sure object->elements()->map() != Heap::dictionary_array_map()

+ // Make sure object->HasFastElements().

// Get the elements array of the object.

__ mov(ebx, FieldOperand(edx, JSObject::kElementsOffset));

// Check that the object is in fast mode (not dictionary).

__ cmp(FieldOperand(ebx, HeapObject::kMapOffset),

- Immediate(Factory::hash_table_map()));

- __ j(equal, &miss, not_taken);

+ Immediate(Factory::fixed_array_map()));

+ __ j(not_equal, &miss, not_taken);

break;

default:

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »