Issue 159451: Disk Cache: Delete chained block files when they become empty....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159451: Disk Cache: Delete chained block files when they become empty.... (Closed)

Created:
11 years, 4 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk Cache: Delete chained block files when they become empty. We were leaving empty block files in the chain, and worst of all, not reusing them because we were thinking that these files were "almost full". Now we also check for empty files when the cache starts. BUG=16740 TEST=unittest. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21762

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -22 lines)			Patch
M	net/disk_cache/block_files.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/disk_cache/block_files.cc	View	6 chunks	+62 lines, -16 lines	0 comments	Download
M	net/disk_cache/block_files_unittest.cc	View	2 chunks	+53 lines, -3 lines	0 comments	Download
M	net/disk_cache/entry_impl.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages