Issue 159436: gtk: Use the requested window bounds when determining the location of the sou...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159436: gtk: Use the requested window bounds when determining the location of the sou... (Closed)

Created:
11 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

gtk: Use the requested window bounds when determining the location of the source tab. This is necessary because we move the hidden source tab during a drag, and gtk does not update the allocation of hidden widgets. BUG=16918, 17712 TEST=Extensive tab dragging. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21729

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -7 lines)			Patch
M	chrome/browser/gtk/tabs/dragged_tab_controller_gtk.cc	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages