Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 159428: Some base/ progress towards building on Linux x86-64. (Closed)

Created:
11 years, 5 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Some base/ progress towards building on Linux x86-64. - Use long for int64 (still 64 bits) to avoid annoying nspr clash. - Fix some incorrect define guards and add some functions to atomicops.

Patch Set 1 #

Patch Set 2 : ug #

Total comments: 2

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M base/atomicops.h View 3 chunks +6 lines, -4 lines 0 comments Download
M base/atomicops_internals_x86_gcc.h View 1 chunk +17 lines, -0 lines 0 comments Download
M base/basictypes.h View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
11 years, 5 months ago (2009-07-27 20:35:46 UTC) #1
Mark Mentovai
11 years, 5 months ago (2009-07-27 21:04:04 UTC) #2
lg
tm

http://codereview.chromium.org/159428/diff/1001/1004
File base/basictypes.h (right):

http://codereview.chromium.org/159428/diff/1001/1004#newcode29
Line 29: // The NSPR system headers define 64-bit as long when possible.  In
order to
Put long inside |these| so that English speakers don't come along and think you
miswrote "as long as possible."

http://codereview.chromium.org/159428/diff/1001/1004#newcode52
Line 52: // See the comment above about NSPR and 64-bit.
Why don't you just move these typedefs up above to live with the int64 ones?

Powered by Google App Engine
This is Rietveld 408576698