src/api.cc - Issue 1594017: Flatten before String::WriteUtf8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1594017: Flatten before String::WriteUtf8 (Closed)

Patch Set: Add isDeadCheck and isFlat tests Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 2100480e85864356f1f6c04cfaee13736eede544..7c196557267e2b947d09195402382ed2b1e0d28a 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -2727,6 +2727,13 @@ int String::Write(uint16_t* buffer, int start, int length) const {

}

+void v8::String::Flatten() {

+ if (IsDeadCheck("v8::String::Flatten()")) return;

+ i::Handle<i::String> str = Utils::OpenHandle(this);

+ i::FlattenString(str);

bool v8::String::IsExternal() const {

EnsureInitialized("v8::String::IsExternal()");

i::Handle<i::String> str = Utils::OpenHandle(this);