Issue 1594003: A patch to fix a couple of issues in interactive_ui_tests on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1594003: A patch to fix a couple of issues in interactive_ui_tests on ChromeOS (Closed)

Created:
10 years, 8 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

A patch to fix a couple of issues in interactive_ui_tests on ChromeOS * Removed two static SkBitmap objects. - default_favicion does not seem to be in use. Removed along with InitClass. - Moved to local static and moved to heap. SkBitmap destructor was failing on exit (in pthread_mutex_lock) * Set VIEW_ID_TAB_CONTAINER_FOCUS_VIEW to the tab container (this ID is required in the test) * Use FocusManager and call TabContentsDelegate::TakeFocus in TabContentsViewGtk::TakeFocus. BUG=39736 TEST=none (interactive_ui_tests needs more patch to run) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43617

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -27 lines)			Patch
M	chrome/browser/views/frame/browser_view.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	4 chunks	+5 lines, -17 lines	0 comments	Download
M	chrome/browser/views/tab_contents/native_tab_contents_container_gtk.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/views/tab_contents/tab_contents_view_gtk.cc	View	1 chunk	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages