X64: Add mov rax,(mem64) to disassembler.

X64: Add mov rax,(mem64) to disassembler.

Committed: http://code.google.com/p/v8/source/detail?r=2540

[Lasse Reichstein, 2009-07-27 09:16:21]

LGTM.

http://codereview.chromium.org/159397/diff/1/2
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/159397/diff/1/2#newcode1350
Line 1350: reinterpret_cast<byte*>(
Use "Address" instead of "byte*".

http://codereview.chromium.org/159397/diff/1/2#newcode1357
Line 1357: NameOfAddress(*reinterpret_cast<byte**>(data+1)));
Use "Address*" instead of "byte**" (Much more readable!)

http://codereview.chromium.org/159397/diff/1/2#newcode1367
Line 1367: switch (operand_size()) {
Would it be possible to combine the two cases that only differ on the format
string?

http://codereview.chromium.org/159397/diff/1/2#newcode1371
Line 1371: *reinterpret_cast<int32_t*>(data + 1))));
ditto.

http://codereview.chromium.org/159397/diff/1/2#newcode1377
Line 1377: NameOfAddress(*reinterpret_cast<byte**>(data+1)));
And ditto.

[William Hesse, 2009-07-27 10:22:46]

http://codereview.chromium.org/159397/diff/1/2
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/159397/diff/1/2#newcode1350
Line 1350: reinterpret_cast<byte*>(
On 2009/07/27 09:16:21, Lasse Reichstein wrote:
> Use "Address" instead of "byte*".

Address is not defined in the disassembler.  The V8 header defining it is not
used.

http://codereview.chromium.org/159397/diff/1/2#newcode1357
Line 1357: NameOfAddress(*reinterpret_cast<byte**>(data+1)));
On 2009/07/27 09:16:21, Lasse Reichstein wrote:
> Use "Address*" instead of "byte**" (Much more readable!)

no

http://codereview.chromium.org/159397/diff/1/2#newcode1367
Line 1367: switch (operand_size()) {
On 2009/07/27 09:16:21, Lasse Reichstein wrote:
> Would it be possible to combine the two cases that only differ on the format
> string?

Yes, and I have no done so, so done.

http://codereview.chromium.org/159397/diff/1/2#newcode1371
Line 1371: *reinterpret_cast<int32_t*>(data + 1))));
On 2009/07/27 09:16:21, Lasse Reichstein wrote:
> ditto.

no

http://codereview.chromium.org/159397/diff/1/2#newcode1377
Line 1377: NameOfAddress(*reinterpret_cast<byte**>(data+1)));
On 2009/07/27 09:16:21, Lasse Reichstein wrote:
> And ditto.

no