Issue 159361: re-do CL 2136 - move image_diff to tools/imagediff, add deps to test_shell...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159361: re-do CL 2136 - move image_diff to tools/imagediff, add deps to test_shell... (Closed)

Created:
11 years, 5 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), M-A Ruel

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

re-do CL 2136 - move image_diff to tools/imagediff, add deps to test_shell moving image_diff from chrome/tools/test/image_diff to tools/imagediff (not moving to tools/image_diff to avoid some svn unpleasantness with that directory having been created in CL 21366). Also change test_shell.gyp to depend on everything needed to run the layout tests. R=darin@chromium.org TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21584

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -376 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/tools/test/image_diff/image_diff.cc	View	1 chunk	+0 lines, -364 lines	0 comments	Download
A +	tools/imagediff/image_diff.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	tools/imagediff/image_diff.gyp	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 4 months ago (2009-08-04 16:51:38 UTC) #3

On 2009/07/24 21:33:52, darin wrote:
> LGTM

YOU FORGOT TO SVN:IGNORE THE GENERATED PROJECT FILES. (I'll do because you're
not alone)

Expand Messages | Collapse Messages