linux: obey window positioning information when bounds are overridden

chrome/browser/gtk/browser_window_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/browser_window_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
 #include "app/resource_bundle.h"
@@ skipping 1052 matching lines @@
   geometry.min_width = 1;
   geometry.min_height = 1;
   gtk_window_set_geometry_hints(window_, NULL, &geometry, GDK_HINT_MIN_SIZE);
 
   if (browser_->GetSavedMaximizedState())
     gtk_window_maximize(window_);
   else
     gtk_window_unmaximize(window_);
 
   gfx::Rect bounds = browser_->GetSavedWindowBounds();
-  // Note that calling SetBounds() here is incorrect, as that sets a forced
-  // position on the window and we intentionally *don't* do that.  We tested
-  // many programs and none of them restored their position on Linux.
-  gtk_window_resize(window_, bounds.width(), bounds.height());
+  // We don't blindly call SetBounds here, that sets a forced position
+  // on the window and we intentionally *don't* do that for normal
+  // windows.  We tested many programs and none of them restored their
+  // position on Linux.
+  //
+  // However, in cases like dropping a tab where the bounds are
+  // specifically set, we do want to position explicitly.
+  if (browser_->bounds_overridden()) {
+    SetBounds(bounds);
+  } else {
+    // Ignore the position but obey the size.
+    gtk_window_resize(window_, bounds.width(), bounds.height());
+  }
 }
 
 void BrowserWindowGtk::ConnectHandlersToSignals() {
   g_signal_connect(window_, "delete-event",
                    G_CALLBACK(MainWindowDeleteEvent), this);
   g_signal_connect(window_, "destroy",
                    G_CALLBACK(MainWindowDestroy), this);
   g_signal_connect(window_, "configure-event",
                    G_CALLBACK(MainWindowConfigured), this);
   g_signal_connect(window_, "window-state-event",
@@ skipping 472 matching lines @@
       *edge = GDK_WINDOW_EDGE_NORTH_EAST;
     } else if (y < bounds_.height() - kResizeAreaCornerSize) {
       *edge = GDK_WINDOW_EDGE_EAST;
     } else {
       *edge = GDK_WINDOW_EDGE_SOUTH_EAST;
     }
     return true;
   }
   NOTREACHED();
 }