Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: net/base/address_list_unittest.cc

Issue 1593015: HostResolver supports optional CNAME lookups. (Closed)
Patch Set: Addressing wtc's nits. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/address_list.h" 5 #include "net/base/address_list.h"
6 6
7 #include "base/string_util.h" 7 #include "base/string_util.h"
8 #include "net/base/host_resolver_proc.h" 8 #include "net/base/host_resolver_proc.h"
9 #include "net/base/net_util.h" 9 #include "net/base/net_util.h"
10 #include "net/base/sys_addrinfo.h" 10 #include "net/base/sys_addrinfo.h"
11 #if defined(OS_WIN) 11 #if defined(OS_WIN)
12 #include "net/base/winsock_init.h" 12 #include "net/base/winsock_init.h"
13 #endif 13 #endif
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace { 16 namespace {
17 17
18 // Use getaddrinfo() to allocate an addrinfo structure. 18 // Use getaddrinfo() to allocate an addrinfo structure.
19 void CreateAddressList(const std::string& hostname, 19 void CreateAddressList(const std::string& hostname,
20 net::AddressList* addrlist, int port) { 20 int port,
21 net::AddressList* addrlist) {
21 #if defined(OS_WIN) 22 #if defined(OS_WIN)
22 net::EnsureWinsockInit(); 23 net::EnsureWinsockInit();
23 #endif 24 #endif
24 int rv = SystemHostResolverProc(hostname, 25 int rv = SystemHostResolverProc(hostname,
25 net::ADDRESS_FAMILY_UNSPECIFIED, 26 net::ADDRESS_FAMILY_UNSPECIFIED,
27 0,
26 addrlist); 28 addrlist);
27 EXPECT_EQ(0, rv); 29 EXPECT_EQ(0, rv);
28 addrlist->SetPort(port); 30 addrlist->SetPort(port);
29 } 31 }
30 32
31 void CreateLongAddressList(net::AddressList* addrlist, int port) { 33 void CreateLongAddressList(net::AddressList* addrlist, int port) {
32 CreateAddressList("192.168.1.1", addrlist, port); 34 CreateAddressList("192.168.1.1", port, addrlist);
33 net::AddressList second_list; 35 net::AddressList second_list;
34 CreateAddressList("192.168.1.2", &second_list, port); 36 CreateAddressList("192.168.1.2", port, &second_list);
35 addrlist->Append(second_list.head()); 37 addrlist->Append(second_list.head());
36 } 38 }
37 39
38 TEST(AddressListTest, GetPort) { 40 TEST(AddressListTest, GetPort) {
39 net::AddressList addrlist; 41 net::AddressList addrlist;
40 CreateAddressList("192.168.1.1", &addrlist, 81); 42 CreateAddressList("192.168.1.1", 81, &addrlist);
41 EXPECT_EQ(81, addrlist.GetPort()); 43 EXPECT_EQ(81, addrlist.GetPort());
42 44
43 addrlist.SetPort(83); 45 addrlist.SetPort(83);
44 EXPECT_EQ(83, addrlist.GetPort()); 46 EXPECT_EQ(83, addrlist.GetPort());
45 } 47 }
46 48
47 TEST(AddressListTest, Assignment) { 49 TEST(AddressListTest, Assignment) {
48 net::AddressList addrlist1; 50 net::AddressList addrlist1;
49 CreateAddressList("192.168.1.1", &addrlist1, 85); 51 CreateAddressList("192.168.1.1", 85, &addrlist1);
50 EXPECT_EQ(85, addrlist1.GetPort()); 52 EXPECT_EQ(85, addrlist1.GetPort());
51 53
52 // Should reference the same data as addrlist1 -- so when we change addrlist1 54 // Should reference the same data as addrlist1 -- so when we change addrlist1
53 // both are changed. 55 // both are changed.
54 net::AddressList addrlist2 = addrlist1; 56 net::AddressList addrlist2 = addrlist1;
55 EXPECT_EQ(85, addrlist2.GetPort()); 57 EXPECT_EQ(85, addrlist2.GetPort());
56 58
57 addrlist1.SetPort(80); 59 addrlist1.SetPort(80);
58 EXPECT_EQ(80, addrlist1.GetPort()); 60 EXPECT_EQ(80, addrlist1.GetPort());
59 EXPECT_EQ(80, addrlist2.GetPort()); 61 EXPECT_EQ(80, addrlist2.GetPort());
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // Changes to addrlist1 are not reflected in addrlist2. 100 // Changes to addrlist1 are not reflected in addrlist2.
99 addrlist1.SetPort(70); 101 addrlist1.SetPort(70);
100 addrlist2.SetPort(90); 102 addrlist2.SetPort(90);
101 103
102 EXPECT_EQ(70, addrlist1.GetPort()); 104 EXPECT_EQ(70, addrlist1.GetPort());
103 EXPECT_EQ(90, addrlist2.GetPort()); 105 EXPECT_EQ(90, addrlist2.GetPort());
104 } 106 }
105 107
106 TEST(AddressListTest, Append) { 108 TEST(AddressListTest, Append) {
107 net::AddressList addrlist1; 109 net::AddressList addrlist1;
108 CreateAddressList("192.168.1.1", &addrlist1, 11); 110 CreateAddressList("192.168.1.1", 11, &addrlist1);
109 EXPECT_EQ(11, addrlist1.GetPort()); 111 EXPECT_EQ(11, addrlist1.GetPort());
110 net::AddressList addrlist2; 112 net::AddressList addrlist2;
111 CreateAddressList("192.168.1.2", &addrlist2, 12); 113 CreateAddressList("192.168.1.2", 12, &addrlist2);
112 EXPECT_EQ(12, addrlist2.GetPort()); 114 EXPECT_EQ(12, addrlist2.GetPort());
113 115
114 ASSERT_TRUE(addrlist1.head()->ai_next == NULL); 116 ASSERT_TRUE(addrlist1.head()->ai_next == NULL);
115 addrlist1.Append(addrlist2.head()); 117 addrlist1.Append(addrlist2.head());
116 ASSERT_TRUE(addrlist1.head()->ai_next != NULL); 118 ASSERT_TRUE(addrlist1.head()->ai_next != NULL);
117 119
118 net::AddressList addrlist3; 120 net::AddressList addrlist3;
119 addrlist3.Copy(addrlist1.head()->ai_next, false); 121 addrlist3.Copy(addrlist1.head()->ai_next, false);
120 EXPECT_EQ(12, addrlist3.GetPort()); 122 EXPECT_EQ(12, addrlist3.GetPort());
121 } 123 }
122 124
125 static const char* kCanonicalHostname = "canonical.bar.com";
126
127 TEST(AddressListTest, Canonical) {
128 // Create an addrinfo with a canonical name.
129 sockaddr_in address;
130 // The contents of address do not matter for this test,
131 // so just zero-ing them out for consistency.
132 memset(&address, 0x0, sizeof(address));
133 struct addrinfo ai;
134 memset(&ai, 0x0, sizeof(ai));
135 ai.ai_family = AF_INET;
136 ai.ai_socktype = SOCK_STREAM;
137 ai.ai_addrlen = sizeof(address);
138 ai.ai_addr = reinterpret_cast<sockaddr*>(&address);
139 ai.ai_canonname = const_cast<char *>(kCanonicalHostname);
140
141 // Copy the addrinfo struct into an AddressList object and
142 // make sure it seems correct.
143 net::AddressList addrlist1;
144 addrlist1.Copy(&ai, true);
145 const struct addrinfo* addrinfo1 = addrlist1.head();
146 EXPECT_TRUE(addrinfo1 != NULL);
147 EXPECT_TRUE(addrinfo1->ai_next == NULL);
148 std::string canon_name1;
149 EXPECT_TRUE(addrlist1.GetCanonicalName(&canon_name1));
150 EXPECT_EQ("canonical.bar.com", canon_name1);
151
152 // Copy the AddressList to another one.
153 net::AddressList addrlist2;
154 addrlist2.Copy(addrinfo1, true);
155 const struct addrinfo* addrinfo2 = addrlist2.head();
156 EXPECT_TRUE(addrinfo2 != NULL);
157 EXPECT_TRUE(addrinfo2->ai_next == NULL);
158 EXPECT_TRUE(addrinfo2->ai_canonname != NULL);
159 EXPECT_NE(addrinfo1, addrinfo2);
160 EXPECT_NE(addrinfo1->ai_canonname, addrinfo2->ai_canonname);
161 std::string canon_name2;
162 EXPECT_TRUE(addrlist2.GetCanonicalName(&canon_name2));
163 EXPECT_EQ("canonical.bar.com", canon_name2);
164
165 // Make sure that GetCanonicalName correctly returns false
166 // when ai_canonname is NULL.
167 ai.ai_canonname = NULL;
168 net::AddressList addrlist_no_canon;
169 addrlist_no_canon.Copy(&ai, true);
170 std::string canon_name3 = "blah";
171 EXPECT_FALSE(addrlist_no_canon.GetCanonicalName(&canon_name3));
172 EXPECT_EQ("blah", canon_name3);
173 }
174
123 } // namespace 175 } // namespace
OLDNEW
« net/base/address_list.cc ('K') | « net/base/address_list.cc ('k') | net/base/host_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698