linux: generalize desktop environment guessing to encompass KDE

linux: generalize desktop environment guessing to encompass KDE

BUG=17363

[Lei Zhang, 2009-07-23 21:16:53]

http://codereview.chromium.org/159297/diff/12/13
File base/linux_util.cc (right):

http://codereview.chromium.org/159297/diff/12/13#newcode104
Line 104: // it seems these other variables are reliably set in the proper
contexts.
GNOME_DESKTOP_SESSION_ID is slowly being deprecated. Newer versions of Gnome
will set DESKTOP_SESSION. Can you put that code back?

[Evan Martin, 2009-07-23 21:31:04]

On 2009/07/23 21:16:53, Lei Zhang wrote:
> GNOME_DESKTOP_SESSION_ID is slowly being deprecated. Newer versions of Gnome
> will set DESKTOP_SESSION. Can you put that code back?

On my system, DESKTOP_SESSION is "default" while the former is set.
In this future world, can we actually rely on DESKTOP_SESSION?

[Lei Zhang, 2009-07-23 21:45:09]

On 2009/07/23 21:31:04, Evan Martin wrote:
> On 2009/07/23 21:16:53, Lei Zhang wrote:
> > GNOME_DESKTOP_SESSION_ID is slowly being deprecated. Newer versions of Gnome
> > will set DESKTOP_SESSION. Can you put that code back?
> 
> On my system, DESKTOP_SESSION is "default" while the former is set.
> In this future world, can we actually rely on DESKTOP_SESSION?

I noticed that as well. In GDM, if only I explicitly set the desktop to Gnome,
then I get DESKTOP_SESSION=gnome. And if I select KDE, then DESKTOP_SESSION=kde.

We can rely on it, but if it doesn't exist or is set to "default", then we need
to fallback to the other ways of checking.

We probably should also file a bug upstream telling them not to set it to
"default".

[Mike Mammarella, 2009-07-23 22:01:30]

On 2009/07/23 21:45:09, Lei Zhang wrote:
> On 2009/07/23 21:31:04, Evan Martin wrote:
> > On 2009/07/23 21:16:53, Lei Zhang wrote:
> > > GNOME_DESKTOP_SESSION_ID is slowly being deprecated. Newer versions of
Gnome
> > > will set DESKTOP_SESSION. Can you put that code back?
> > 
> > On my system, DESKTOP_SESSION is "default" while the former is set.
> > In this future world, can we actually rely on DESKTOP_SESSION?
> 
> I noticed that as well. In GDM, if only I explicitly set the desktop to Gnome,
> then I get DESKTOP_SESSION=gnome. And if I select KDE, then
DESKTOP_SESSION=kde.
> 
> We can rely on it, but if it doesn't exist or is set to "default", then we
need
> to fallback to the other ways of checking.
> 
> We probably should also file a bug upstream telling them not to set it to
> "default".

KDM also sets DESKTOP_SESSION (for me, to "kde"). It does sound like we should
check that first and only try other approaches if it isn't helpful.

[Evan Martin, 2009-07-23 22:03:08]

Cool, thanks.  New version up with DESKTOP_SESSION checked first (and test
updated).

[Mike Mammarella, 2009-07-23 22:08:20]

On 2009/07/23 22:03:08, Evan Martin wrote:
> Cool, thanks.  New version up with DESKTOP_SESSION checked first (and test
> updated).

LGTM

[Evan Martin, 2009-07-23 22:09:14]

BTW, the reason I wrote this was as a precursor to the password stuff, but after
talking with Mike I think he's on top of it.  So I was glad I'd written this
separately since it'll still be useful eventually even though it makes no
functional change right now.  :(