Issue 159236: Force inlining of some handle methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159236: Force inlining of some handle methods. (Closed)

Created:
11 years, 5 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Christian Plesner Hansen, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Force inlining of some handle methods. Committed: http://code.google.com/p/v8/source/detail?r=2529

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	include/v8.h	View	1 2 3	7 chunks	+10 lines, -10 lines	0 comments	Download

Total messages: 5 (0 generated)

Christian Plesner Hansen

Lgtm. How much of a different does it make in performance?

11 years, 5 months ago (2009-07-23 06:09:17 UTC) #2

Mads Ager (chromium)

Actually, does this make a difference at all. The implementation is not in a header ...

11 years, 5 months ago (2009-07-23 07:34:12 UTC) #4

Mads Ager (chromium)

11 years, 5 months ago (2009-07-23 07:35:30 UTC) #5

Oh, Christian just pointed out to me that these methods are template methods and
therefore the implementation is in the header file. :-)

LGTM