Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: webkit/glue/chrome_client_impl.cc

Issue 159222: Checking tooltip against empty before adding Unicode marks (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/chrome_client_impl.cc
===================================================================
--- webkit/glue/chrome_client_impl.cc (revision 21293)
+++ webkit/glue/chrome_client_impl.cc (working copy)
@@ -513,14 +513,16 @@
if (webview_->delegate()) {
std::wstring tooltip_text_as_wstring =
webkit_glue::StringToStdWString(tooltip_text);
- if (dir == WebCore::LTR) {
- // Force the tooltip to have LTR directionality.
- tooltip_text_as_wstring.insert(0, 1, WebCore::leftToRightEmbed);
- tooltip_text_as_wstring.push_back(WebCore::popDirectionalFormatting);
- } else {
- // Force the tooltip to have RTL directionality.
- tooltip_text_as_wstring.insert(0, 1, WebCore::rightToLeftEmbed);
- tooltip_text_as_wstring.push_back(WebCore::popDirectionalFormatting);
+ if (!tooltip_text_as_wstring.empty()) {
+ if (dir == WebCore::LTR) {
+ // Force the tooltip to have LTR directionality.
+ tooltip_text_as_wstring.insert(0, 1, WebCore::leftToRightEmbed);
+ tooltip_text_as_wstring.push_back(WebCore::popDirectionalFormatting);
+ } else {
+ // Force the tooltip to have RTL directionality.
+ tooltip_text_as_wstring.insert(0, 1, WebCore::rightToLeftEmbed);
+ tooltip_text_as_wstring.push_back(WebCore::popDirectionalFormatting);
+ }
}
webview_->delegate()->SetTooltipText(webview_, tooltip_text_as_wstring);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698