Issue 1592001: Simplify IA32 code generator API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1592001: Simplify IA32 code generator API. (Closed)

Created:
10 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Simplify IA32 code generator API. Cut down on the number of arguments passed to the various binary operation code generator functions by passing along the expression itself, rather than a subset of its fields. Committed: http://code.google.com/p/v8/source/detail?r=4319

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -74 lines)			Patch
M	src/ast.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/ast.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	2 chunks	+6 lines, -12 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	18 chunks	+53 lines, -56 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages