Issue 159169: GTK: Center the tab text by its meanline, rather than halfway between its asc...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159169: GTK: Center the tab text by its meanline, rather than halfway between its asc... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
glen, James Hawkins, Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Center the tab text by its meanline, rather than halfway between its ascent and descent. The tab text was previously one pixel too high. With this patch it matches Windows. I think before Evan's recent font size patch, this issue was hidden by favorable rounding. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21256

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 5 months ago (2009-07-21 23:43:21 UTC) #3

Thanks for fixing that.  I noticed it after my patch but didn't think the fix
would be easy.

Expand Messages | Collapse Messages