This fixes a number of things that are warnings in the Mac compiler....

This fixes a number of things that are warnings in the Mac compiler.

It fixes at least two real bugs, one in the tar generator, and one
in stream_bank.h.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21227

[gman, 2009-07-21 23:15:19]

LGTM

What changed in test2.tar.gz?

[ruudvangaal, 2009-09-01 12:09:49]

bitmap_dds.c contains a DXT1 chunk flip bug in line 69.

Line is: block[6] = block[5];
should be: block[6] = tmp;

http://codereview.chromium.org/159168/diff/1/24
File core/cross/bitmap_dds.cc (left):

http://codereview.chromium.org/159168/diff/1/24#oldcode69
Line 69: block[6] = block[5];
should be: block[6]=tmp

[ruudvangaal, 2009-09-01 13:28:10]

bitmap_dds.cc contains bugs in the DXT5 full flip. Line 150 & 153 should use
>>16 instead of just >>8.

http://codereview.chromium.org/159168/diff/1/24
File core/cross/bitmap_dds.cc (left):

http://codereview.chromium.org/159168/diff/1/24#oldcode150
Line 150: block[4] = (line_3_2 & 0xff0000) >> 8;
Strips all bits to 0; use >>16 instead.

http://codereview.chromium.org/159168/diff/1/24#oldcode153
Line 153: block[7] = (line_1_0 & 0xff0000) >> 8;
Strips all bits to 0; use >>16 instead.