Issue 159167: Refactoring to share MockAudioOutputStream implementations across 3 platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159167: Refactoring to share MockAudioOutputStream implementations across 3 platforms (Closed)

Created:
11 years, 5 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Refactoring to share MockAudioOutputStream implementations across 3 platforms Re-trying the previous CL. The last change got reverted because of valgrind failure. TBR=scherkus Original CL: http://codereview.chromium.org/155471 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21242

Patch Set 1 #

Patch Set 2 : the same as before #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+191 lines, -197 lines)			Patch
M	chrome/browser/renderer_host/audio_renderer_host_unittest.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	media/audio/audio_output.h	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	media/audio/fake_audio_output_stream.h	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	media/audio/fake_audio_output_stream.cc	View	1 chunk	+72 lines, -0 lines	0 comments	Download
M	media/audio/linux/alsa_output.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/linux/alsa_output.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/audio/linux/audio_manager_linux.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/linux/audio_manager_linux.cc	View	3 chunks	+10 lines, -11 lines	0 comments	Download
M	media/audio/mac/audio_manager_mac.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/mac/audio_manager_mac.cc	View	3 chunks	+7 lines, -9 lines	0 comments	Download
M	media/audio/mac/audio_output_mac.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/mac/audio_output_mac.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/audio/simple_sources.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/audio/simple_sources_unittest.cc	View	2 chunks	+46 lines, -0 lines	0 comments	Download
M	media/audio/win/audio_manager_win.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	media/audio/win/audio_output_win.cc	View	6 chunks	+2 lines, -92 lines	0 comments	Download
M	media/audio/win/audio_output_win_unittest.cc	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	media/audio/win/waveout_output_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/win/waveout_output_win.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/media.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages