gtk: Two fixes for the tab leak:...

chrome/browser/gtk/tabs/tab_strip_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/tabs/tab_strip_gtk.h"
 
 #include <algorithm>
 
 #include "app/gfx/canvas_paint.h"
 #include "app/l10n_util.h"
@@ skipping 811 matching lines @@
   for (; it != tab_data_.end(); ++it) {
     if (it->tab == tab) {
       if (!model_->closing_all())
         NOTREACHED() << "Leaving in an inconsistent state!";
       tab_data_.erase(it);
       break;
     }
   }
 
   gtk_container_remove(GTK_CONTAINER(tabstrip_.get()), tab->widget());
-  delete tab;
+  // If we delete the dragged source tab here, the gtk drag-n-drop API won't
+  // get a change to clean up and remove any references it's added to the tab
+  // widget, so we'll leak the widget.
+  MessageLoop::current()->DeleteSoon(FROM_HERE, tab);

[tony, 2009/07/21 22:55:44]

You're sure that the gtk d&d api will get to run before the tab is deleted?

 
   // Force a layout here, because if we've just quickly drag detached a Tab,
   // the stopping of the active animation above may have left the TabStrip in a
   // bad (visual) state.
   Layout();
 }
 
 gfx::Rect TabStripGtk::GetIdealBounds(int index) {
   DCHECK(index >= 0 && index < GetTabCount());
   return tab_data_.at(index).ideal_bounds;
@@ skipping 1076 matching lines @@
   message.set_type(TabOverviewTypes::Message::WM_SWITCH_TO_OVERVIEW_MODE);
   GtkWidget* browser_widget = GTK_WIDGET(
       static_cast<BrowserWindowGtk*>(browser->window())->GetNativeHandle());
   message.set_param(0, x11_util::GetX11WindowFromGtkWidget(browser_widget));
   TabOverviewTypes::instance()->SendMessage(message);
 
   UserMetrics::RecordAction(L"TabOverview_PressedTabOverviewButton",
                             tabstrip->model_->profile());
 }
 #endif