Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 159165: Split NSSDecryptor out into platform specific files.... (Closed)

Created:
11 years, 5 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
Reviewers:
kuchhal
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google), wtc
Visibility:
Public.

Description

Split NSSDecryptor out into platform specific files. This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs. BUG=http://crbug.com/13929 TEST=Case 1: Start chrome. Use firefox import utility. Browse to some https site. Shouldn't crash. Case 2: Start chrome. Browse to some https site. Use firefox import utility. Continue browsing https sites. Shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21251

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -1226 lines) Patch
M chrome/browser/importer/firefox2_importer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.h View 2 chunks +0 lines, -154 lines 0 comments Download
M chrome/browser/importer/firefox_importer_utils.cc View 2 chunks +0 lines, -300 lines 0 comments Download
MM chrome/browser/importer/firefox_importer_utils_linux.cc View 1 chunk +0 lines, -20 lines 0 comments Download
MM chrome/browser/importer/firefox_importer_utils_mac.cc View 2 chunks +0 lines, -15 lines 0 comments Download
MM chrome/browser/importer/firefox_importer_utils_win.cc View 2 chunks +0 lines, -85 lines 0 comments Download
A chrome/browser/importer/nss_decryptor.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A + chrome/browser/importer/nss_decryptor.cc View 2 chunks +8 lines, -415 lines 0 comments Download
A chrome/browser/importer/nss_decryptor_linux.h View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/importer/nss_decryptor_linux.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/browser/importer/nss_decryptor_mac.h View 1 2 3 4 chunks +23 lines, -97 lines 0 comments Download
A + chrome/browser/importer/nss_decryptor_win.h View 3 chunks +8 lines, -72 lines 0 comments Download
A + chrome/browser/importer/nss_decryptor_win.cc View 3 chunks +88 lines, -68 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
willchan no longer on Chromium
11 years, 5 months ago (2009-07-21 23:09:49 UTC) #1
kuchhal
lgtm. Instead of refactoring code would it have been possible to check if NSS was ...
11 years, 5 months ago (2009-07-22 00:16:14 UTC) #2
willchan no longer on Chromium
11 years, 5 months ago (2009-07-22 00:23:12 UTC) #3
On 2009/07/22 00:16:14, kuchhal wrote:
> lgtm.
> 
> Instead of refactoring code would it have been possible to check if NSS was
> already initialized on Linux and skip the init/shutdown step if so? Or may be
> get rid of shutdown step altogether?

Yes, that was possible, although I ended up having to toss in a lot of #if
defined stuff around and it got messy.  firefox_imported_utils.h had defined
lots of the symbols which we needed to get from the nss headers, so it required
lots of #ifs to work around that and also elsewhere.  Also, this prevents linux
from compiling unnecessary code it doesn't need.

Powered by Google App Engine
This is Rietveld 408576698