Issue 159158: Make middle-clicking on GTK tabs not count for closing if you release off of ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159158: Make middle-clicking on GTK tabs not count for closing if you release off of ... (Closed)

Created:
11 years, 5 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make middle-clicking on GTK tabs not count for closing if you release off of the tab itself. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21221

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/gtk/tabs/tab_gtk.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 5 months ago (2009-07-21 21:43:09 UTC) #2

lgtm with nit

http://codereview.chromium.org/159158/diff/1/2
File chrome/browser/gtk/tabs/tab_gtk.cc (right):

http://codereview.chromium.org/159158/diff/1/2#newcode182
Line 182: event->x < tab->bounds().width() && event->y < tab->bounds().height())
{
I think it would be better to use widget->allocation.width/height

Expand Messages | Collapse Messages