Issue 159154: GTK Themes: Fixes button state on pressed back/forward buttons and toolbar items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159154: GTK Themes: Fixes button state on pressed back/forward buttons and toolbar items. (Closed)

Created:
11 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK Themes: Fixes button state on pressed back/forward buttons and toolbar items. This patch fixes two related problems: 1) Holding down back/forward now stay pressed while the menu is shown. 2) Buttons on the "toolbar" now emulate GTK's toolbar behaviour of only showing the border on hover. http://crbug.com/17308 http://crbug.com/17340 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21233

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -17 lines)			Patch
	M	chrome/browser/gtk/custom_button.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/gtk/custom_button.cc	View		8 chunks	+22 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm2

Expand Messages | Collapse Messages