Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Issue 159148: Add <if> blocks to xtb files in the simplest possible way. This currently (Closed)

Created:
11 years, 5 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, jungshik at Google
Visibility:
Public.

Description

Add <if> blocks to xtb files in the simplest possible way. This currently only supports checking the OS, but we can add more information if necessary. BUG=16884

Patch Set 1 #

Patch Set 2 : only reader change #

Total comments: 4

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M tools/grit/grit/xtb_reader.py View 1 2 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
There's an example of the syntax in patchset 1. It's pretty much the same as ...
11 years, 5 months ago (2009-07-21 20:34:06 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/159148/diff/6/1001 File tools/grit/grit/xtb_reader.py (right): http://codereview.chromium.org/159148/diff/6/1001#newcode46 Line 46: assert self.if_expr is None Is there some ...
11 years, 5 months ago (2009-07-22 00:29:54 UTC) #2
tony
11 years, 5 months ago (2009-07-22 00:37:21 UTC) #3
http://codereview.chromium.org/159148/diff/6/1001
File tools/grit/grit/xtb_reader.py (right):

http://codereview.chromium.org/159148/diff/6/1001#newcode46
Line 46: assert self.if_expr is None
On 2009/07/22 00:29:55, Evan Martin wrote:
> Is there some way to pass a string to "assert" so if someone catches this
> they'll get a useful error message?

Done.

http://codereview.chromium.org/159148/diff/6/1001#newcode52
Line 52: if_result = True
On 2009/07/22 00:29:55, Evan Martin wrote:
> Might be clearer with a name like "should run callback", since it's also used
in
> the case where there's no "if" block.

Done.

Powered by Google App Engine
This is Rietveld 408576698