Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2689)

Unified Diff: chrome/browser/gtk/info_bubble_gtk.cc

Issue 159147: Make GTK file dialog box modal for parent window, instead of for the entire... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/dialogs_gtk.cc ('k') | chrome/browser/renderer_host/render_widget_host_view_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/info_bubble_gtk.cc
===================================================================
--- chrome/browser/gtk/info_bubble_gtk.cc (revision 21201)
+++ chrome/browser/gtk/info_bubble_gtk.cc (working copy)
@@ -209,6 +209,13 @@
// of the info bubble. We don't use an X grab since that would steal
// keystrokes from your window manager, prevent you from interacting with
// other applications, etc.
+ //
+ // Before adding the grab, we need to ensure that the bubble is added
+ // to the window group of the top level window. This ensures that the
+ // grab only affects the current browser window, and not all the open
+ // browser windows in the application.
+ gtk_window_group_add_window(gtk_window_get_group(transient_toplevel),
+ GTK_WINDOW(window_));
gtk_grab_add(window_);
registrar_.Add(this, NotificationType::ACTIVE_WINDOW_CHANGED,
« no previous file with comments | « chrome/browser/gtk/dialogs_gtk.cc ('k') | chrome/browser/renderer_host/render_widget_host_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698