chrome/browser/dom_ui/dom_ui_theme_source.cc - Issue 159146: Sometimes it's possible for a DOMUI to request images that don't exist (theme...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_ui/dom_ui_theme_source.cc

Issue 159146: Sometimes it's possible for a DOMUI to request images that don't exist (theme... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/dom_ui/dom_ui_theme_source.cc

===================================================================

--- chrome/browser/dom_ui/dom_ui_theme_source.cc (revision 21189)

+++ chrome/browser/dom_ui/dom_ui_theme_source.cc (working copy)

@@ -148,7 +148,11 @@

DCHECK(tp);

SkBitmap* image = tp->GetBitmapNamed(resource_id);

- DCHECK(image);

+ if (!image || image->empty()) {

+ SendResponse(request_id, NULL);

+ return;

+ }

std::vector<unsigned char> png_bytes;

PNGEncoder::EncodeBGRASkBitmap(*image, false, &png_bytes);

« no previous file with comments | « no previous file | no next file » | no next file with comments »