GTK Themes: Get text color from a label object; this should fix some theme text problems.

GTK Themes: Get text color from a label object; this should fix some theme text problems.

GTK Themes can set colors on a per widget basis, and many do. Previously we were getting
the text color from a GtkWindow object, which sometimes is wrong--the theme just sets the
text color on labels...

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21200

[tony, 2009-07-21 18:35:10]

LGTM

http://codereview.chromium.org/159143/diff/1/3
File chrome/browser/gtk/gtk_theme_provider.h (right):

http://codereview.chromium.org/159143/diff/1/3#newcode93
Line 93: // A GtkWidget that exists only so we can look at its properties (and
take
Nit: Update the comment since it now applies to two widgets.

[Evan Stade, 2009-07-21 19:12:19]

http://codereview.chromium.org/159143/diff/1/2
File chrome/browser/gtk/gtk_theme_provider.cc (right):

http://codereview.chromium.org/159143/diff/1/2#newcode180
Line 180: SetThemeColorFromGtk(kColorBackgroundTabText,
shouldn't TabText and BackgroundTabText be different? TabText has to stand out
against ColorToolbar whereas BackgroundTabText has to stand out against
ColorFrame

[Elliot Glaysher, 2009-07-21 19:21:36]

http://codereview.chromium.org/159143/diff/1/2
File chrome/browser/gtk/gtk_theme_provider.cc (right):

http://codereview.chromium.org/159143/diff/1/2#newcode180
Line 180: SetThemeColorFromGtk(kColorBackgroundTabText,
On 2009/07/21 19:12:19, Evan Stade wrote:
> shouldn't TabText and BackgroundTabText be different? TabText has to stand out
> against ColorToolbar whereas BackgroundTabText has to stand out against
> ColorFrame

They should, but that's a larger change then this. I'm still sketching out how
I'm going to do that.

[Evan Stade, 2009-07-21 19:37:55]

ok this lgtm