DevTools Profiler: small UI improvements....

webkit/glue/devtools/js/profiler_processor.js

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Profiler processor is used to process log file produced
  * by V8 and produce an internal profile representation which is used
  * for building profile views in 'Profiles' tab.
  */
 goog.provide('devtools.profiler.Processor');
@@ skipping 161 matching lines @@
       'end-code-region': null});
 
 
   /**
    * Callback that is called when a new profile is encountered in the log.
    * @type {function()}
    */
   this.startedProfileProcessing_ = null;
 
   /**
+   * Callback that is called periodically to display processing status.
+   * @type {function()}
+   */
+  this.profileProcessingStatus_ = null;
+
+  /**
    * Callback that is called when a profile has been processed and is ready
    * to be shown.
    * @type {function(devtools.profiler.ProfileView)}
    */
   this.finishedProfileProcessing_ = null;
 
   /**
    * The current profile.
    * @type {devtools.profiler.JsProfile}
    */
   this.currentProfile_ = null;
 
   /**
    * Builder of profile views. Created during "profiler,begin" event processing.
    * @type {devtools.profiler.WebKitViewBuilder}
    */
   this.viewBuilder_ = null;
 
   /**
    * Next profile id.
    * @type {number}
    */
   this.profileId_ = 1;
+
+  /**
+   * Counter for processed ticks.
+   * @type {number}
+   */
+  this.ticksCount_ = 0;
 };
 goog.inherits(devtools.profiler.Processor, devtools.profiler.LogReader);
 
 
 /**
  * @override
  */
 devtools.profiler.Processor.prototype.printError = function(str) {
   debugPrint(str);
 };
 
 
 /**
  * @override
  */
 devtools.profiler.Processor.prototype.skipDispatch = function(dispatch) {
   return dispatch.needsProfile && this.currentProfile_ == null;
 };
 
 
 /**
  * Sets profile processing callbacks.
  *
  * @param {function()} started Started processing callback.
  * @param {function(devtools.profiler.ProfileView)} finished Finished
  *     processing callback.
  */
 devtools.profiler.Processor.prototype.setCallbacks = function(
-    started, finished) {
+    started, processing, finished) {
   this.startedProfileProcessing_ = started;
+  this.profileProcessingStatus_ = processing;
   this.finishedProfileProcessing_ = finished;
 };
 
 
 /**
  * An address for the fake "(program)" entry. WebKit's visualisation
  * has assumptions on how the top of the call tree should look like,
  * and we need to add a fake entry as the topmost function. This
  * address is chosen because it's the end address of the first memory
  * page, which is never used for code or data, but only as a guard
@@ skipping 13 matching lines @@
  * @param {function(devtools.profiler.ProfileView)} callback Callback function.
  */
 devtools.profiler.Processor.prototype.setNewProfileCallback = function(
     callback) {
   this.newProfileCallback_ = callback;
 };
 
 
 devtools.profiler.Processor.prototype.processProfiler_ = function(
     state, params) {
+  var processingInterval = null;
   switch (state) {
     case 'resume':
       if (this.currentProfile_ == null) {
         this.currentProfile_ = new devtools.profiler.JsProfile();
         // see the comment for devtools.profiler.Processor.PROGRAM_ENTRY
         this.currentProfile_.addCode(
           'Function', '(program)',
           devtools.profiler.Processor.PROGRAM_ENTRY, 1);
         if (this.startedProfileProcessing_) {
           this.startedProfileProcessing_();
         }
+        this.ticksCount_ = 0;
+        var self = this;
+        if (this.profileProcessingStatus_) {
+          processingInterval = window.setInterval(
+              function() { self.profileProcessingStatus_(self.ticksCount_); },
+              1000);
+        }
       }
       break;
     case 'pause':
       if (this.currentProfile_ != null) {
+        window.clearInterval(processingInterval);

[pfeldman, 2009/07/21 14:58:49]

should this be checked for nullness?

[mnaganov (inactive), 2009/07/21 15:06:29]

window.clearInterval(null) is harmless.

         if (this.finishedProfileProcessing_) {
           this.finishedProfileProcessing_(this.createProfileForView());
         }
         this.currentProfile_ = null;
       }
       break;
     case 'begin':
       var samplingRate = NaN;
       if (params.length > 0) {
         samplingRate = parseInt(params[0]);
@@ skipping 26 matching lines @@
 devtools.profiler.Processor.prototype.processCodeDelete_ = function(start) {
   this.currentProfile_.deleteCode(start);
 };
 
 
 devtools.profiler.Processor.prototype.processTick_ = function(
     pc, sp, vmState, stack) {
   // see the comment for devtools.profiler.Processor.PROGRAM_ENTRY
   stack.push(devtools.profiler.Processor.PROGRAM_ENTRY_STR);
   this.currentProfile_.recordTick(this.processStack(pc, stack));
+  this.ticksCount_++;
 };
 
 
 /**
  * Creates a profile for further displaying in ProfileView.
  */
 devtools.profiler.Processor.prototype.createProfileForView = function() {
   var profile = this.viewBuilder_.buildView(
       this.currentProfile_.getTopDownProfile());
   profile.uid = this.profileId_++;
   profile.title = UserInitiatedProfileName + '.' + profile.uid;
   return profile;
 };