Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/tab_contents/tab_contents_view_gtk.cc

Issue 159130: Fix two crashers with TOOLKIT_VIEWS build:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/controls/native/native_view_host_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
===================================================================
--- chrome/browser/views/tab_contents/tab_contents_view_gtk.cc (revision 21157)
+++ chrome/browser/views/tab_contents/tab_contents_view_gtk.cc (working copy)
@@ -96,6 +96,10 @@
}
TabContentsViewGtk::~TabContentsViewGtk() {
+ // Just deleting the object doesn't destroy the GtkWidget. We need to do that
+ // manually, and synchronously, since subsequent signal handlers may expect
+ // to locate this object.
+ CloseNow();
}
void TabContentsViewGtk::CreateView() {
« no previous file with comments | « no previous file | views/controls/native/native_view_host_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698