Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 159124: linux: add command-line flag to allow debugging of sandboxed processes (Closed)

Created:
11 years, 5 months ago by Antoine Labour
Modified:
9 years, 7 months ago
Reviewers:
agl, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: add command-line flag to allow debugging of sandboxed processes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21248

Patch Set 1 #

Patch Set 2 : Make it actually work #

Patch Set 3 : add missing include #

Total comments: 2

Patch Set 4 : fix typo #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/browser/zygote_host_linux.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 1 2 3 4 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Antoine Labour
11 years, 5 months ago (2009-07-21 04:20:39 UTC) #1
agl
I'm not sure this will actually work, did you test it? I would suspect that ...
11 years, 5 months ago (2009-07-21 04:24:38 UTC) #2
Antoine Labour
On 2009/07/21 04:24:38, agl wrote: > I'm not sure this will actually work, did you ...
11 years, 5 months ago (2009-07-21 04:35:16 UTC) #3
Evan Martin
http://codereview.chromium.org/159124/diff/11/14 File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/159124/diff/11/14#newcode554 Line 554: // Allows debugging of sanboxed processes (see zygote_main_linux.cc). ...
11 years, 5 months ago (2009-07-21 06:00:08 UTC) #4
Antoine Labour
http://codereview.chromium.org/159124/diff/11/14 File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/159124/diff/11/14#newcode554 Line 554: // Allows debugging of sanboxed processes (see zygote_main_linux.cc). ...
11 years, 5 months ago (2009-07-21 06:21:18 UTC) #5
agl
11 years, 5 months ago (2009-07-21 21:02:14 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698