Issue 159104: Silence a false coverity warning by changing the code a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159104: Silence a false coverity warning by changing the code a bit. (Closed)

Created:
11 years, 5 months ago by Munjal (Google)

Modified:
9 years ago

Reviewers:
Aaron Boodman, Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Silence a false coverity warning by changing the code a bit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21447

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
	M	base/json_reader.cc	View	1 2	1 chunk	+4 lines, -8 lines	0 comments	Download
	M	base/json_reader_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Munjal (Google)

I actually had a bug in my previous change; Doh. Can you take a quick ...

11 years, 5 months ago (2009-07-21 18:36:27 UTC) #3

Erik does not do reviews

Do the unit tests test for this? If not, could you please add a new ...

11 years, 5 months ago (2009-07-22 14:20:22 UTC) #4

Munjal (Google)

Added unit tests for comments. Can one of you take a quick look?

11 years, 5 months ago (2009-07-23 20:30:06 UTC) #5

Erik does not do reviews

11 years, 5 months ago (2009-07-23 22:02:30 UTC) #6

Can you add one or more cases that look like comments but fail to parse? 
Otherwise, LGTM