Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1591009: Pepper audio basic functionality unit test, take 3. (Closed)

Created:
10 years, 8 months ago by neb
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ncarter (slow), fbarchard, Alpha Left Google, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, idana, jam, Aaron Boodman, dpranke+watch_chromium.org, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin (slow to review), amit, tim (not reviewing), scherkus (not reviewing)
Visibility:
Public.

Description

Pepper audio basic functionality unit test, take 3. Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -13 lines) Patch
M chrome/common/ipc_test_sink.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/common/ipc_test_sink.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/mock_render_thread.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/mock_render_thread.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/renderer/pepper_devices.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/pepper_devices_unittest.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 2 chunks +8 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698