Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 1591004: RunAllPendingEvents -> ui_test_utils::RunAllPendingInMessageLoop (Closed)
Patch Set: " Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "app/combobox_model.h" 7 #include "app/combobox_model.h"
8 #include "app/l10n_util.h" 8 #include "app/l10n_util.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/scoped_ptr.h" 10 #include "base/scoped_ptr.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "chrome/browser/chromeos/cros/cros_library.h" 12 #include "chrome/browser/chromeos/cros/cros_library.h"
13 #include "chrome/browser/chromeos/cros/mock_login_library.h" 13 #include "chrome/browser/chromeos/cros/mock_login_library.h"
14 #include "chrome/browser/chromeos/cros/mock_network_library.h" 14 #include "chrome/browser/chromeos/cros/mock_network_library.h"
15 #include "chrome/browser/chromeos/cros/network_library.h" 15 #include "chrome/browser/chromeos/cros/network_library.h"
16 #include "chrome/browser/chromeos/login/network_selection_view.h" 16 #include "chrome/browser/chromeos/login/network_selection_view.h"
17 #include "chrome/browser/chromeos/login/network_screen.h" 17 #include "chrome/browser/chromeos/login/network_screen.h"
18 #include "chrome/browser/chromeos/login/mock_screen_observer.h" 18 #include "chrome/browser/chromeos/login/mock_screen_observer.h"
19 #include "chrome/browser/chromeos/login/view_screen.h" 19 #include "chrome/browser/chromeos/login/view_screen.h"
20 #include "chrome/browser/chromeos/login/wizard_controller.h" 20 #include "chrome/browser/chromeos/login/wizard_controller.h"
21 #include "chrome/browser/chromeos/login/wizard_in_process_browser_test.h" 21 #include "chrome/browser/chromeos/login/wizard_in_process_browser_test.h"
22 #include "chrome/browser/chromeos/login/wizard_screen.h" 22 #include "chrome/browser/chromeos/login/wizard_screen.h"
23 #include "chrome/test/ui_test_utils.h"
23 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
24 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
25 #include "testing/gmock/include/gmock/gmock.h" 26 #include "testing/gmock/include/gmock/gmock.h"
26 #include "views/controls/combobox/combobox.h" 27 #include "views/controls/combobox/combobox.h"
27 28
28 namespace chromeos { 29 namespace chromeos {
29 using ::testing::AnyNumber; 30 using ::testing::AnyNumber;
30 using ::testing::InvokeWithoutArgs; 31 using ::testing::InvokeWithoutArgs;
31 using ::testing::Return; 32 using ::testing::Return;
32 using ::testing::ReturnRef; 33 using ::testing::ReturnRef;
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 EXPECT_CALL(*mock_screen_observer, 234 EXPECT_CALL(*mock_screen_observer,
234 OnExit(ScreenObserver::NETWORK_CONNECTED)) 235 OnExit(ScreenObserver::NETWORK_CONNECTED))
235 .Times(1); 236 .Times(1);
236 controller()->set_observer(mock_screen_observer.get()); 237 controller()->set_observer(mock_screen_observer.get());
237 238
238 // Emulate combobox selection. 239 // Emulate combobox selection.
239 EthernetExpectations(true, false); 240 EthernetExpectations(true, false);
240 WifiCellularNetworksExpectations(); 241 WifiCellularNetworksExpectations();
241 network_screen->ItemChanged(&combobox, 0, 1); 242 network_screen->ItemChanged(&combobox, 0, 1);
242 network_view->SetSelectedNetworkItem(1); 243 network_view->SetSelectedNetworkItem(1);
243 RunAllPendingEvents(); 244 ui_test_utils::RunAllPendingInMessageLoop();
244 controller()->set_observer(NULL); 245 controller()->set_observer(NULL);
245 } 246 }
246 247
247 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, WifiSelected) { 248 IN_PROC_BROWSER_TEST_F(NetworkScreenTest, WifiSelected) {
248 ASSERT_TRUE(controller()); 249 ASSERT_TRUE(controller());
249 NetworkLibrary* network_library = 250 NetworkLibrary* network_library =
250 chromeos::CrosLibrary::Get()->GetNetworkLibrary(); 251 chromeos::CrosLibrary::Get()->GetNetworkLibrary();
251 NetworkScreen* network_screen = controller()->GetNetworkScreen(); 252 NetworkScreen* network_screen = controller()->GetNetworkScreen();
252 ASSERT_TRUE(network_screen != NULL); 253 ASSERT_TRUE(network_screen != NULL);
253 NetworkSelectionView* network_view = network_screen->view(); 254 NetworkSelectionView* network_view = network_screen->view();
(...skipping 16 matching lines...) Expand all
270 271
271 // Emulate combobox selection. 272 // Emulate combobox selection.
272 EthernetExpectations(false, false); 273 EthernetExpectations(false, false);
273 WifiCellularNetworksExpectations(); 274 WifiCellularNetworksExpectations();
274 WifiSsidExpectation(empty_string); 275 WifiSsidExpectation(empty_string);
275 network_screen->ItemChanged(&combobox, 0, 1); 276 network_screen->ItemChanged(&combobox, 0, 1);
276 network_view->SetSelectedNetworkItem(1); 277 network_view->SetSelectedNetworkItem(1);
277 EXPECT_CALL(*mock_network_library_, 278 EXPECT_CALL(*mock_network_library_,
278 ConnectToWifiNetwork(A<WifiNetwork>(), string16())) 279 ConnectToWifiNetwork(A<WifiNetwork>(), string16()))
279 .Times(1); 280 .Times(1);
280 RunAllPendingEvents(); 281 ui_test_utils::RunAllPendingInMessageLoop();
281 ASSERT_EQ(2, network_screen->GetItemCount()); 282 ASSERT_EQ(2, network_screen->GetItemCount());
282 283
283 // Emulate connecting WiFi network. 284 // Emulate connecting WiFi network.
284 wifi_networks_.clear(); 285 wifi_networks_.clear();
285 wifi.connecting = true; 286 wifi.connecting = true;
286 wifi_networks_.push_back(wifi); 287 wifi_networks_.push_back(wifi);
287 EthernetExpectations(false, false); 288 EthernetExpectations(false, false);
288 WifiExpectations(false, true); 289 WifiExpectations(false, true);
289 WifiCellularNetworksExpectations(); 290 WifiCellularNetworksExpectations();
290 WifiSsidExpectation(wifi_ssid); 291 WifiSsidExpectation(wifi_ssid);
291 network_screen->NetworkChanged(network_library); 292 network_screen->NetworkChanged(network_library);
292 ASSERT_EQ(network_screen, controller()->current_screen()); 293 ASSERT_EQ(network_screen, controller()->current_screen());
293 294
294 scoped_ptr<MockScreenObserver> mock_screen_observer(new MockScreenObserver()); 295 scoped_ptr<MockScreenObserver> mock_screen_observer(new MockScreenObserver());
295 EXPECT_CALL(*mock_screen_observer, 296 EXPECT_CALL(*mock_screen_observer,
296 OnExit(ScreenObserver::NETWORK_CONNECTED)) 297 OnExit(ScreenObserver::NETWORK_CONNECTED))
297 .Times(1); 298 .Times(1);
298 controller()->set_observer(mock_screen_observer.get()); 299 controller()->set_observer(mock_screen_observer.get());
299 300
300 // Emulate connected WiFi network. 301 // Emulate connected WiFi network.
301 wifi_networks_.clear(); 302 wifi_networks_.clear();
302 wifi.connecting = false; 303 wifi.connecting = false;
303 wifi.connected = true; 304 wifi.connected = true;
304 wifi_networks_.push_back(wifi); 305 wifi_networks_.push_back(wifi);
305 EthernetExpectations(false, false); 306 EthernetExpectations(false, false);
306 WifiExpectations(true, false); 307 WifiExpectations(true, false);
307 WifiCellularNetworksExpectations(); 308 WifiCellularNetworksExpectations();
308 WifiSsidExpectation(wifi_ssid); 309 WifiSsidExpectation(wifi_ssid);
309 network_screen->NetworkChanged(network_library); 310 network_screen->NetworkChanged(network_library);
310 RunAllPendingEvents(); 311 ui_test_utils::RunAllPendingInMessageLoop();
311 controller()->set_observer(NULL); 312 controller()->set_observer(NULL);
312 } 313 }
313 314
314 } // namespace chromeos 315 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698