Explicitly use the ULL suffix to specify a large constant.

Explicitly use the ULL suffix to specify a large constant.

This hopefully fixes the ARM build error.

TBR = wad@chromium.org

[Will Drewry, 2010-03-30 14:40:13]

LGTM

http://codereview.chromium.org/1591001/diff/1/2
File src/platform/vboot_reference/tests/big_firmware_tests.c (right):

http://codereview.chromium.org/1591001/diff/1/2#newcode19
src/platform/vboot_reference/tests/big_firmware_tests.c:19: #define
BIG_FIRMWARE_SIZE ((uint64_t) 0x100000000ULL)
Have you run into any weirdness else where in the firmware code (not just
tests)?

If so, you may want to add some compile-time checking to ensure that
constants/max/etc aren't being truncated in unexpected ways.  E.g., this could
be done as: 
#define BIG_FIRMWARE_SIZE U64(0x100000000)

and have it include a platform.h (or in utility.h) that contains some basic
sanity checking:
#if __WORDSIZE == 64                                                            
#  define U64(x) ((uint64_t)(x ## UL))                                          
#elif __WORDSIZE == 32                                                          
#  define U64(x) ((uint64_t)(x ## ULL))                                         
#else                                                                           
#  error "Unsupported compilation target platform"                              
#endif                                                                          

If it seemed practical, you could also expand it to support U32, U16, etc to
ensure that all values are as declared.   However that may be overkill. (Of
course, we could also expand coverage to do any other type and math checking
throughout the code)