Issue 159095: Don't dispatch the extensions bindings unload event during GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159095: Don't dispatch the extensions bindings unload event during GC. (Closed)

Created:
11 years, 5 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Don't dispatch the extensions bindings unload event during GC. BUG=17289 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21197

Patch Set 2 : compile fix (merge trouble) #

Total comments: 2

Patch Set 3 : messed up the if #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -12 lines)			Patch
	M	chrome/renderer/extensions/event_bindings.cc	View	1 2	4 chunks	+26 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rafaelw

http://codereview.chromium.org/159095/diff/4/1002 File chrome/renderer/extensions/event_bindings.cc (right): http://codereview.chromium.org/159095/diff/4/1002#newcode158 Line 158: if (!(*context_iter)->parent_context.IsEmpty()) { This appears to only handle ...

11 years, 5 months ago (2009-07-21 00:47:02 UTC) #2

Matt Perry

11 years, 5 months ago (2009-07-21 00:48:29 UTC) #3

LGTM