Issue 159079: X64: Fix compiler complaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159079: X64: Fix compiler complaint (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Fix compiler complaint Committed: http://code.google.com/p/v8/source/detail?r=2514

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/x64/disasm-x64.cc	View	1 2	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

William Hesse

TBR: iposva. Do you have a better, preferred way to solve this warning?

11 years, 5 months ago (2009-07-20 18:00:26 UTC) #1

iposva

LGTM otherwise. -ip http://codereview.chromium.org/159079/diff/1/2 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/159079/diff/1/2#newcode1368 Line 1368: value = 0; // Avoid ...

11 years, 5 months ago (2009-07-20 18:03:32 UTC) #2

William Hesse

http://codereview.chromium.org/159079/diff/7/8 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/159079/diff/7/8#newcode1352 Line 1352: int64_t value = 0; The USE macro won't ...

11 years, 5 months ago (2009-07-20 20:18:28 UTC) #3

LGTM -ip

Expand Messages | Collapse Messages