Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: chrome/browser/extensions/extension_process_manager.cc

Issue 159073: Addressing minor review comments in ExtensionProcessManager... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_process_manager.cc
===================================================================
--- chrome/browser/extensions/extension_process_manager.cc (revision 21073)
+++ chrome/browser/extensions/extension_process_manager.cc (working copy)
@@ -85,11 +85,14 @@
}
void ExtensionProcessManager::RegisterExtensionProcess(
- std::string extension_id, int process_id) {
+ const std::string& extension_id, int process_id) {
ProcessIDMap::const_iterator it = process_ids_.find(extension_id);
if (it != process_ids_.end() && (*it).second == process_id)
return;
+ // Extension ids should get removed from the map before the process ids get
+ // reused from a dead renderer.
+ DCHECK(it == process_ids_.end());
process_ids_[extension_id] = process_id;
ExtensionsService* extension_service =
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698