Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 159061: Tries to retrieve all post_match_families in the font file to support non-asc... (Closed)

Created:
11 years, 5 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Tries to retrieve all post_match_families in the font file to support non-ascii fonts. This patch should fix CHECK failures like this: yusukes@yusukes-desktop:~/chromium2/src/build$ ../sconsbuild/Release/chrome [20666:20666:544922424350:FATAL:/home/yusukes/chromium2/src/app/gfx/font_skia.cc(90)] Check failed: tf. Could not find font: IPA モナー Pゴシック Since some fonts have multiple font family names, the FontConfigDirect::Match() function should try to compare post_config_family with _all_ family names in the font, rather than with only the first (usually English) family name. For example, a popular Japanese font called ipagpmona.ttf has two family names, an English name and an internationalized (Japanese) one, and post_config_family for the font can be either the English name or the Japanese name depending on the situation. $ showttf /usr/share/fonts/truetype/ttf-ipamonafont/ipagp-mona.ttf | egrep -A 1 -e "platform=1 .* Family" platform=1 plat spec encoding=0 language=0 name=1 Family strlen=14 stroff=288 IPAMonaPGothic -- platform=1 plat spec encoding=1 language=b name=1 Family strlen=20 stroff=871 IPA <83><82><83>i<81>[ P<83>S<83>V<83>b<83>N Original review URL: http://codereview.chromium.org/155751 BUG=12530 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M skia/ext/SkFontHost_fontconfig_direct.cpp View 1 chunk +20 lines, -10 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698