Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 159059: Enable DOM_STORAGE in our build. (Closed)

Created:
11 years, 5 months ago by jorlow
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, brettw, jam, Ben Goodger (Google)
Visibility:
Public.

Description

Enable DOM_STORAGE in our build. Put LocalStorage and SessionStorage behind their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.--enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash.Originally Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=21059 but then backed out due to include path issues.BUG=4360 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21157

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -10 lines) Patch
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
A webkit/api/src/StorageNamespaceProxy.h View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/api/src/StorageNamespaceProxy.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 1 2 5 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jorlow
I had to revert this CL when I checked it in because there's some issue ...
11 years, 5 months ago (2009-07-18 22:23:14 UTC) #1
darin (slow to review)
LGTM When I need to revert a revert, I just literally do that :-) That ...
11 years, 5 months ago (2009-07-19 03:54:38 UTC) #2
jorlow
11 years, 5 months ago (2009-07-19 18:46:00 UTC) #3
On 2009/07/19 03:54:38, darin wrote:
> LGTM
> 
> When I need to revert a revert, I just literally do that :-)  That way, I'm
> assured that it is the exact same CL and there is nothing more for anyone to
> review anyways.

I tried to revert the revert.  Unfortunately, I don't think the revert script
understands how to add files back in.  Normally, that's what I'd do though.

Powered by Google App Engine
This is Rietveld 408576698