Chromium Code Reviews

Issue 159057: Changing the include from "base/gfx/platform_canvas.h" to "skia/ext/platform_... (Closed)

Created:
11 years, 5 months ago by tfarina (gmail-do not use)
Modified:
9 years, 7 months ago
Reviewers:
brettw, awong
CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, John Grabowski, kylep, darin (slow to review), scherkus (not reviewing)
Visibility:
Public.

Description

Changing the include from "base/gfx/platform_canvas.h" to "skia/ext/platform_canvas.h" BUG=None TEST=None

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Stats (+4 lines, -64 lines)
M base/base.gyp View 1 chunk +0 lines, -5 lines 0 comments
D base/gfx/platform_canvas.h View 1 chunk +0 lines, -7 lines 0 comments
D base/gfx/platform_canvas_linux.h View 1 chunk +0 lines, -12 lines 0 comments
D base/gfx/platform_canvas_mac.h View 1 chunk +0 lines, -12 lines 0 comments
D base/gfx/platform_device_linux.h View 1 chunk +0 lines, -12 lines 0 comments
D base/gfx/platform_device_mac.h View 1 chunk +0 lines, -12 lines 0 comments
M webkit/glue/media/video_renderer_impl.h View 1 chunk +1 line, -1 line 0 comments
M webkit/glue/webmediaplayer_impl.h View 2 chunks +1 line, -1 line 0 comments
M webkit/tools/test_shell/mac/webview_host.mm View 1 chunk +1 line, -1 line 0 comments
M webkit/tools/test_shell/mac/webwidget_host.mm View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 11 (0 generated)
tfarina (gmail-do not use)
brettw, I did the task that is in base/gfx/platform_canvas.h Can you review this to me? ...
11 years, 5 months ago (2009-07-18 17:43:57 UTC) #1
brettw
Is it possible to delete the old platform_canvas.h now?
11 years, 5 months ago (2009-07-20 17:39:37 UTC) #2
tfarina (gmail-do not use)
On 2009/07/20 17:39:37, brettw wrote: > Is it possible to delete the old platform_canvas.h now? ...
11 years, 5 months ago (2009-07-20 20:09:32 UTC) #3
brettw
On 2009/07/20 20:09:32, tfarina wrote: > On 2009/07/20 17:39:37, brettw wrote: > > Is it ...
11 years, 5 months ago (2009-07-20 20:11:19 UTC) #4
awong
LGTM for media portions (and for other parts too, but I don't really know that ...
11 years, 5 months ago (2009-07-20 20:11:23 UTC) #5
tfarina (gmail-do not use)
11 years, 5 months ago (2009-07-21 02:44:29 UTC) #6
tfarina (gmail-do not use)
brettw I also noticed that the following files can be excluded from the project. Should ...
11 years, 5 months ago (2009-07-21 05:35:12 UTC) #7
brettw
On 2009/07/21 05:35:12, tfarina wrote: > brettw I also noticed that the following files can ...
11 years, 5 months ago (2009-07-21 18:39:22 UTC) #8
tfarina (gmail-do not use)
11 years, 5 months ago (2009-07-21 19:11:15 UTC) #9
brettw
LGTM
11 years, 5 months ago (2009-07-21 19:24:22 UTC) #10
awong
11 years, 5 months ago (2009-07-21 23:44:53 UTC) #11
LGTM

Powered by Google App Engine