Implementing accelerators for Linux toolkit_views

This CL adds accelerators to the Linux toolkit views.
The MessageLoop had to be modified to support Dispatchers on Linux.

BUG=None
TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22210

[jcampan, 2009-07-31 18:23:16]

Ricardo, could you look at message_loop.* message_pump_glib.* files?

Ben, could you look at the other files?

[Ben Goodger (Google), 2009-07-31 19:51:01]

views bits LGTM.

http://codereview.chromium.org/159046/diff/310/324
File views/event_gtk.cc (right):

http://codereview.chromium.org/159046/diff/310/324#newcode12
Line 12: // In order for accelerators to work, we need to unify that.  The right
solution
"normalize" not "unify"

[rvargas (doing something else), 2009-07-31 20:37:03]

The message loop LGTM, but I'm adding Evan just in case.

http://codereview.chromium.org/159046/diff/310/318
File base/message_loop.cc (right):

http://codereview.chromium.org/159046/diff/310/318#newcode591
Line 591: #if defined(OS_WIN)
nit: could you move this block before the previous one (win || linux) to match
the new function order of the header file?.

[Evan Martin, 2009-07-31 21:07:56]

http://codereview.chromium.org/159046/diff/310/316
File base/message_loop.h (right):

http://codereview.chromium.org/159046/diff/310/316#newcode434
Line 434: // Please see message_pump_win/message_pump_glib  for definitions of
these
nit: extra space

http://codereview.chromium.org/159046/diff/310/317
File base/message_pump_glib.h (right):

http://codereview.chromium.org/159046/diff/310/317#newcode53
Line 53: // Like MessagePump::Run, but GtkEvent objects are routed through
dispatcher.
typo: GdkEvent