Issue 159040: Fix another d&d crash that happens when the tab contents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159040: Fix another d&d crash that happens when the tab contents (Closed)

Created:
11 years, 5 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix another d&d crash that happens when the tab contents is swapped out while a drag is happening. Since the tab contents is swapped out, our RVH that the drag started on is no longer valid. Simply null out the pointer and no longer try to send feedback to the drag source. This allows the user to continue the drag even though the source RVH is gone. BUG=16073

Patch Set 1 #

Total comments: 1

Patch Set 2 : revise comment #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -10 lines)			Patch
M	chrome/browser/tab_contents/web_drag_source.h	View		4 chunks	+14 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drag_source.cc	View		4 chunks	+30 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tab_contents/tab_contents_view_win.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM (sorry for the delayed review!) http://codereview.chromium.org/159040/diff/1/5 File webkit/glue/webview_impl.cc (right): http://codereview.chromium.org/159040/diff/1/5#newcode1590 Line 1590: // it's ...

11 years, 5 months ago (2009-07-21 04:53:54 UTC) #3

might this also cause a problem on linux?

Expand Messages | Collapse Messages