Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 159029: Add some definitions to npapi/bindings/npapi.h.... (Closed)

Created:
11 years, 5 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
jam, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add some definitions to npapi/bindings/npapi.h. I don't quite understand what all the different versions of npapi.h are about, but this is the minium hackery to get webkit building again. BUG=https://bugs.webkit.org/show_bug.cgi?id=27385 TBR=evan,jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M third_party/npapi/bindings/npapi.h View 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
11 years, 5 months ago (2009-07-17 21:34:04 UTC) #1
Evan Martin
This is gross. Why not just use the upstream file?
11 years, 5 months ago (2009-07-17 21:35:29 UTC) #2
eroman
> This is gross. Why not just use the upstream file? Yeah. Using the upstream ...
11 years, 5 months ago (2009-07-17 21:40:18 UTC) #3
eroman
11 years, 5 months ago (2009-07-17 21:41:06 UTC) #4
I reckon I am going to commit this anyway, since I dont know how long it will
take me to figure out a better solution, and in the meantime everything is
broken.

Powered by Google App Engine
This is Rietveld 408576698